Zotlabs|Hubzilla Development

Caranistar

Wed, 09 Jun 2021 01:48:50 +0000

Hello !@Zotlabs|Hubzilla Development !@zotlabs.org | Hubzilla

Has a #hubzilla dev looked to the #bug posted here: https://ussr.win/link/6715528 ?
Could be involved in issue 1513...

Hubzilla issue1513

show all 18 comments

Max Kostikov

Wed, 09 Jun 2021 08:22:48 +0000 last edited: Wed, 09 Jun 2021 08:32:42 +0000

issue 1513

This issue was fixed.
I don't sure what is about these pictures and why they were posted, but if somebody wants to discuss Hubzilla code the right place to do it is project main repo on Framagit.

Altyr

Wed, 09 Jun 2021 10:32:22 +0000

Obviously, it's a bug in #hubzilla code source.
@Max Kostikov : could you create an issue on Framagit? Registration are closed so I can't create an account and do it myself.

By the way, issue 1513 is still not definitly fixed, and many questions are pending in the issue's discussion.

Max Kostikov

Wed, 09 Jun 2021 10:43:56 +0000

@Altyr

could you create an issue on Framagit?

Why?

By the way, issue 1513 is still not definitly fixed, and many questions are pending in the issue's discussion.

I believe all question were answered already. I don't know what else we can add to this discussion at the moment.

emaxmax

Wed, 09 Jun 2021 15:56:48 +0000

Why?

To fix the pointed bug I guess.
(Can't create account neither, can't help)

I believe all question were answered already

You missed this, this, this, and this.
And don't forget this.

Max Kostikov

Wed, 09 Jun 2021 16:03:13 +0000

@emaxmax

To fix the pointed bug I guess.

You mean something displayed on picture? I believe author able to do it by himself and even more, can provide a patch.

Max Kostikov

Wed, 09 Jun 2021 16:08:35 +0000 last edited: Wed, 09 Jun 2021 16:10:03 +0000

@emaxmax

You missed...

I think that you should not expect detailed answers to every question you have. If you really want to understand how everything works, start your own hub (or rather two) and start learning how this or that piece of code works.
IMHO this is the best and most efficient way.

emaxmax

Wed, 09 Jun 2021 20:49:11 +0000

Thank you for your time, but that is a terrible answer.

Modern code should be (and acutally is) understandable with just a look at the code (and its documentation). Hubzilla dont achieve this, it's alarming.
But there is more.
Someone asked about the bus factor. No anwser yet, but I guess it's around 2 or 3, which is very low for an open source software. I bet this frail rate and the tenuous adoption are linked to the poor quality of the code. The questions asked are representative: the spaghetti code can't be debugged except with try and fail, which is a bad method, and explain why it took you 6 monthes to fix a bug with ultimately 1 line change. (By the way, this bug can occured in all your SQL requests, and this is scary).
I looked to all pictures posted in this folder, and I took time to check that there are real bugs on hubzilla code. I don't know why @Malendur didn't create issue, but you still can do it.
In the meantime, I think Hubzilla is in danger: technical debt increasing, quality too bad to attract other developers, no answers for motivated ones...
By the way, what is the value of Hubzilla's code coverage?

So, to be constructive, there are 2 actions.
First: fix all bugs listed previously. It should be easy for someone who know the code (I can't because of lack of documentation)
Second: refactor all Hubzilla code to use object oriented programation, a popular framework, and documentation and unit test as the new classes are added. If you go that way, I'll help (even with commits if you use a new repository with open registration)

Max Kostikov

Wed, 09 Jun 2021 21:08:08 +0000 last edited: Wed, 09 Jun 2021 21:49:57 +0000

@emaxmax

explain why it took you 6 monthes to fix a bug with ultimately 1 line change. (By the way, this bug can occured in all your SQL requests, and this is scary).

Wrong. There was a several issues involved and several bugs was discovered and fixed within less than one working day after a reproducible case was provided.

Someone asked about the bus factor. No anwser yet, but I guess it's around 2 or 3, which is very low for an open source software.

We invite everyone to become one of these guys.

fix all bugs listed previously

And establish world peace.

refactor all Hubzilla code to use object oriented programation, a popular framework

Personally, I'm not a fan of the cult of object-oriented programming, which is often (but not always) less efficient and makes it difficult to understand the code and also I prefer not to use frameworks and libraries without real need.

And you are welcome (one more time) to join to the development team and make it better.
That's was about "to be constructive".

sync

Wed, 09 Jun 2021 22:20:53 +0000

And you are welcome (one more time) to join to the development team and make it better.

Really? "Welcome"?
Why not answer to the questions the willing developers asked on the issue? That's how you welcome new developers...

less efficient

Modern caches threw this remark away. By the way, there are many performance errors in the code you could fix if this is important for you. But keeping old, outdated, bugged, unmaintainable code just for this false reason is blindness...

Max Kostikov

Wed, 09 Jun 2021 22:25:27 +0000 last edited: Wed, 09 Jun 2021 22:33:07 +0000

@sync

Why not answer to the questions the willing developers asked on the issue?

Because all the questions related to the issue were answered. If there was no answer to something, then this question does not make sense and the explanation of why will take a lot of time with a low chance of being understood.

By the way, there are many performance errors in the code you could fix if this is important for you

That's what I'm trying to do last months. If this important for me. :laughing:

Caranistar

Thu, 10 Jun 2021 00:17:48 +0000

I find that the questions make very sense, and your attitude is deplorable. No wonder you can't manage to attract new developers with that code and that behavior...

emaxmax

Wed, 16 Jun 2021 10:11:45 +0000

@Max Kostikov

Wrong. There was a several issues involved and several bugs was discovered and fixed within less than one working day after a reproducible case was provided.

I can read code. I was talking of the bug reported 6 monthes ago, which was corrected with 1 line in the comit (and no tests updated or documentation added). I know other bugs were fixed too, but they were not reported in the issue.

Personally, I'm not a fan of the cult of object-oriented programming, which is often (but not always) less efficient

I don't know who told you that, but it's completely wrong (OO code are translated in procedural code when the project is built, so they have exaclty the same perf)

Because all the questions related to the issue were answered.

No: I listed 5 questions unanswered.

Max Kostikov

Wed, 16 Jun 2021 19:58:44 +0000 last edited: Wed, 16 Jun 2021 20:08:14 +0000

@emaxmax

I can read code.

It seems you can not which completely deprives value of your entire subsequent text for me.

cb7f604332cf39

Wed, 16 Jun 2021 20:00:00 +0000

We've got Corona-Time. Do you have some time to learn a new language?
May be php fits to your requirements.
Start a fork and rebuild everything from the ground with OO approach.
Cause this is what you're asking for.
It's not that easy as you write.
There won't be a smooth easy migration from procedural to OO.

This is a huge mass of work and you need to understand everything in detail to do this in a propper way.
And not every developer is able to support the object oriented style. Do you do?
Some are no professionals but more hobby developer.
Some of them works in IT but are no developer (like me: I'm a network admin).
My own php skills are limited for example.

As multiple people wrote: this is FOSS.
Lot's of people invested a lot of spare time to write this project over serveral years.
Nobody works here as an full time employee.
In the past we lost some good developers (inclu. Mike, Thomas and others).
These people have their own mind, targets and ideas.
And the history told us that communication between people is sometimes complicated.
Some devs are already burned and gone.

So I just wanne say to all devs: thank you for all the work you made for this great project.
Please take the time you need.

emaxmax

Wed, 16 Jun 2021 20:19:18 +0000

It seems you can not

Yet I can, and I can see poor code poorly patched.

which completely deprives value of your entire subsequent text for me.

This is the way you are going to improve? Denying reality just as you did with the issues you couldn't reproduce? How mature...

sync

Thu, 17 Jun 2021 14:57:52 +0000

It seems @emaxmax is right, unless if, @Max Kostikov, you can point us to the unit test updated, and the documentation improved. I search for a long time (since the bug is actually not fully fixed yet), I dug in your commits, and the rest of the files you didn't update, and I found nothing else. Just this frightening ORDER BY...

Max Kostikov

Thu, 17 Jun 2021 22:17:31 +0000 last edited: Fri, 18 Jun 2021 08:35:24 +0000

@sync
The main issue wasn't related to wiki itself but it helped to fix it.
https://framagit.org/hubzilla/core/-/commit/35df50c39d95e19dcd7e67bd3328059dbb591b66
https://framagit.org/hubzilla/core/-/commit/07525c5b4594858b2b9a748a1d0cbc571fa49c7c
There are the couple of other issues found and fixed when wiki testing
https://framagit.org/hubzilla/core/-/commit/8394d4857c3f7a4fcfdd983348fa7bf81ae76347

sync

Fri, 18 Jun 2021 09:38:25 +0000

So @emaxmax is right: no tests updated, no documentation added. Yet someone pointed it here: https://framagit.org/hubzilla/core/-/commit/8394d4857c3f7a4fcfdd983348fa7bf81ae76347#note_929579
I would add myself that you should not mess SQL and business logic in the same file. Create a method for all your

q("SELECT * FROM item WHERE uid = %d AND resource_type = '%s' AND resource_id = '%s' AND item_deleted = 0

Dev branch heads up!

Mario Vavti

Fri, 21 May 2021 07:26:24 +0000

I will soon start to remove support for legacy zot.

Also i am considering to move the gnu-social addon to addons-unsupported. AFAIK GNU Social supports activitypub by now.

Mario Vavti

Sat, 05 Jun 2021 08:02:18 +0000

Core branch six has been merged into dev and addons branch dcc has been merged into dev.

Language switch

Hilmar R

Sat, 08 May 2021 07:53:59 +0000

Mario, your question "why ajax" I think I understood correctly now only. With the language switch I had the question where to start in the at the interaction. A common approach would be GET() in the corresponding app. But the app Lang would be too late in this use case. The starting point would be the app menu. However, I have not found a suitable entry point in it that is available on every page of the interaction. There is no usable "anchor" in the templates for this. That's why I chose POST() of the Lang app as entry point, and not GET(), because with the logic of immediate language switching GET() can't be relevant at all. Also INIT() is not suitable. Hopefully I have described this understandably.

i18n Lang

Mario Vavti

Sun, 09 May 2021 17:40:23 +0000

My question was more about why using ajax to fetch the languages list at all. You could render it along with the page...

Merging branch air into dev soon

Mario Vavti

Mon, 29 Mar 2021 18:31:46 +0000

In case you don't know what branch air is about: it's an almost complete rewrite of the registration and invitation code by @Hilmar R with many configuration options to prevent spam registrations and a possibility to ease admin approvals by being able to configure open/close time frames.

I think air is more or less ready for merging into dev:

The workflow for most configurations has been simplified (much more work to do here but should be fine for dev)
Security issues resolved (provided passwords have been saved as hex strings)
Timezones issues has been mostly resolved (not sure yet what to do with emails - at the moment we send UTC date/time which is not very friendly because people will have to calculate)
Streamlined default settings (needs more testing and probably minor improvements)

I have had my dev hub running this code for some days now with open registrations (with admin approval) and no email verification (which is not recommended). A one minute registration verification delay and a ten minutes verification time frame has been configured. The result was that non of the bots managed to verify the registration so far...

Mario Vavti

Tue, 06 Apr 2021 08:04:40 +0000

Merged!

If you are an admin of a dev hub, please review your registration settings in /admin/site after next git pull...

Use of Zot icons freely for p.r.?

Witcraft

Sun, 21 Mar 2021 13:16:04 +0000

Can the icons of Zot and Zot-based Software be freely used on public websites for non-commercial purposes of public relations (like explaining things to newcomers)? I figure it is Open Source / CC0, but I want to make sure I do not infringe any rights or code of behavior in the dev community.

Zot icons public relations

hEARt PhoniX

Sun, 21 Mar 2021 15:47:26 +0000

for promoting Hubzilla, go ahead. :)

FourOh-LLC

Wed, 03 Feb 2021 07:35:14 +0000

Quoted below is the text from /var/www/hubzilla/doc/gdpr1.md - which is the file pulled in when the visitor clicks on the Terms of Service during registration. This is from an instance installed by YunoHost (Debian 10, currently) other installations could be different.

Is there a way to plug in some variables which are coming from other screens, such as the Settings or the Admin? Or for the time being just update it manually?

Identity and contact details of controller and data protection officer

[NAME OF COMPANY]
is the controller
[and processor]
of data for the purposes of the DPA 18 and GDPR. 3

If you have any concerns as to how your data is processed you can contact:

[
[NAME]
Data Protection Offer at
[EMAIL ADDRESS]
]
[NAME] [JOB TITLE]
at
[EMAIL ADDRESS]
or you can write to these
individuals using the address of
[]

FourOh-LLC

Wed, 03 Feb 2021 07:38:38 +0000

Newbie here - I forgot to give this a title and cannot edit, but I meant to say "Updating the Terms of Service Page". Sorry!

start.hubzilla.org - considering changes to the hub affecting all

hEARt PhoniX

Tue, 05 Jan 2021 12:10:14 +0000

!!Zotlabs|Hubzilla Development
!!Hubzilla Support Forum

I have just received an abuse notice for the hub. The reason are some spam profiles. I have disabled account registration for now. I am seriously considering taking the whole hub offline, spam account registrations are becoming overwhelming. 30-50 per day.
I have been working on the hub during the last days, trying to find ways to make Hubzilla more accessible for newbies but at the same time considering various options:

enforcing automatically account deletion after 30 days
enforcing a policy no login for 10 days means automatic account deletion
taking the hub offline as a last resort

Automatic account deletion would not have prevented this issue, as the accounts in questions have been registered just about 2 days ago.
If you have got ideas, please do post them.

Andrew

Tue, 05 Jan 2021 13:38:54 +0000

That's disappointing. It is honestly surprising that it took so long for this obvious vulnerability to cause real problems, though. I'm no expert, but there are not many privacy-friendly options for thwarting spam registations on a public site like this. You can require validation of the email address registered (I think you are already doing this) and you can also integrate some kind of CAPTCHA system. Perhaps even the simplest open source CAPTCHA system would be good enough for a site like this.

hEARt PhoniX

Wed, 06 Jan 2021 11:12:47 +0000

I do have implemented some measures, there is an addon in the works that I am using a very early version of. I hope it will see an official release at some time, but I won't tell more right now.

Major updates are finished

hEARt PhoniX

Sun, 06 Dec 2020 16:37:12 +0000

I have now finished the server move and updates of all our infrastructure hubs to 5.0.4

    start.hubzilla.org
    zotlabs.org
    demo.hubzilla.org

There is more work to do, I am working on a way to purge accounts on start on a regular basis, based upon criteria:

    no login for longer than 6 months
    channel attached to account are not clones
    account has got no channel

If you object and / or have got other suggestions, please come forward.

I am still figuring out, how I could do that via a script, but that would have to catch all entries that belong to the account. I have not yet found the appropriate place in the source code where I could view how to drop an account.

hEARt PhoniX

Mon, 07 Dec 2020 15:10:27 +0000

@elmussol Actually I think that's reasonable.

Mario Vavti

Mon, 07 Dec 2020 21:41:02 +0000

Thanks @hEARt PhoniX!

Contribution to documentation

Sat, 05 Dec 2020 19:11:16 +0000

Following another thread about the update to version 50, encouraged to look at the documentation. Where is it? How to contribute?

Areas looked so far:

https://framagit.org/hubzilla
    core
        doc
            german translation, but where is the main table of contents?
    side bar of web site, 'wiki'
        No edit since 3 years
        Deploying hubzillla
            only 'simple vm install' is described
        FAQ
            only '...reduce usages mysql'
    install
    tests

Text above a copy of an earlier post, not visible according to another subscriber.

documentation upgrade update hubzilla50

Contribution to documentation

Sat, 05 Dec 2020 17:34:21 +0000

!Zotlabs|Hubzilla Development
Following another thread about the update to version 50, encouraged to look at the documentation. Where is it? How to contribute?

Areas looked so far:

https://framagit.org/hubzilla
    core
        doc
            german translation, but where is the main table of contents?
    side bar of web site, 'wiki'
        No edit since 3 years
        Deploying hubzillla
            only 'simple vm install' is described
        FAQ
            only '...reduce usages mysql'
    install
    tests

Stefan Holzhauer wrote the following post Thu, 12 Nov 2020 10:55:24 +0000

!Hubzilla Support Forum Update to Hubzilla 5.0: Did not work. At all.

I followed the doc at https://hub.somaton.com/channel/mario?mid=b64.aHR0cHM6Ly9odWIuc29tYXRvbi5jb20vaXRlbS9kYWQ3ZmVmMy1jMzRiLTRiN2YtODAzMy1iMDkwMjY3Y2FhMmY

Hubzilla runs on shared hosting with SSH access

- I created a backup of the installation folder and the database
- I updated via util/udall
- since it is not explained in the installation doc how to check if db updates have been successful applied, I did not check it.
- I ran php util/z6convert.php dry-run - everything seemed to be fine
- I ran php util/z6convert.php

Site became completely unresponsive and did no longer load. I reinstalled the backup so I can now write this. I am back on 4.6 - 1234 without any idea on how to update. Since this is on shared hosting I have no access to the server logs.

Zotlabs|Hubzilla Development

hubzilla-development@zotlabs.org