Zotlabs|Hubzilla Development

Caranistar

Wed, 09 Jun 2021 01:48:50 +0000

Hello !@Zotlabs|Hubzilla Development !@zotlabs.org | Hubzilla

Has a #hubzilla dev looked to the #bug posted here: https://ussr.win/link/6715528 ?
Could be involved in issue 1513...

Hubzilla issue1513

show all 19 Comments

Max Kostikov

Wed, 09 Jun 2021 08:22:48 +0000 last edited: Wed, 09 Jun 2021 08:32:42 +0000

issue 1513

This issue was fixed.
I don't sure what is about these pictures and why they were posted, but if somebody wants to discuss Hubzilla code the right place to do it is project main repo on Framagit.

Altyr

Wed, 09 Jun 2021 10:32:22 +0000

Obviously, it's a bug in #hubzilla code source.
@Max Kostikov : could you create an issue on Framagit? Registration are closed so I can't create an account and do it myself.

By the way, issue 1513 is still not definitly fixed, and many questions are pending in the issue's discussion.

Max Kostikov

Wed, 09 Jun 2021 10:43:56 +0000

@Altyr

could you create an issue on Framagit?

Why?

By the way, issue 1513 is still not definitly fixed, and many questions are pending in the issue's discussion.

I believe all question were answered already. I don't know what else we can add to this discussion at the moment.

emaxmax

Wed, 09 Jun 2021 15:56:48 +0000

Why?

To fix the pointed bug I guess.
(Can't create account neither, can't help)

I believe all question were answered already

You missed this, this, this, and this.
And don't forget this.

Max Kostikov

Wed, 09 Jun 2021 16:03:13 +0000

@emaxmax

To fix the pointed bug I guess.

You mean something displayed on picture? I believe author able to do it by himself and even more, can provide a patch.

Max Kostikov

Wed, 09 Jun 2021 16:08:35 +0000 last edited: Wed, 09 Jun 2021 16:10:03 +0000

@emaxmax

You missed...

I think that you should not expect detailed answers to every question you have. If you really want to understand how everything works, start your own hub (or rather two) and start learning how this or that piece of code works.
IMHO this is the best and most efficient way.

emaxmax

Wed, 09 Jun 2021 20:49:11 +0000

Thank you for your time, but that is a terrible answer.

Modern code should be (and acutally is) understandable with just a look at the code (and its documentation). Hubzilla dont achieve this, it's alarming.
But there is more.
Someone asked about the bus factor. No anwser yet, but I guess it's around 2 or 3, which is very low for an open source software. I bet this frail rate and the tenuous adoption are linked to the poor quality of the code. The questions asked are representative: the spaghetti code can't be debugged except with try and fail, which is a bad method, and explain why it took you 6 monthes to fix a bug with ultimately 1 line change. (By the way, this bug can occured in all your SQL requests, and this is scary).
I looked to all pictures posted in this folder, and I took time to check that there are real bugs on hubzilla code. I don't know why @Malendur didn't create issue, but you still can do it.
In the meantime, I think Hubzilla is in danger: technical debt increasing, quality too bad to attract other developers, no answers for motivated ones...
By the way, what is the value of Hubzilla's code coverage?

So, to be constructive, there are 2 actions.
First: fix all bugs listed previously. It should be easy for someone who know the code (I can't because of lack of documentation)
Second: refactor all Hubzilla code to use object oriented programation, a popular framework, and documentation and unit test as the new classes are added. If you go that way, I'll help (even with commits if you use a new repository with open registration)

Max Kostikov

Wed, 09 Jun 2021 21:08:08 +0000 last edited: Wed, 09 Jun 2021 21:49:57 +0000

@emaxmax

explain why it took you 6 monthes to fix a bug with ultimately 1 line change. (By the way, this bug can occured in all your SQL requests, and this is scary).

Wrong. There was a several issues involved and several bugs was discovered and fixed within less than one working day after a reproducible case was provided.

Someone asked about the bus factor. No anwser yet, but I guess it's around 2 or 3, which is very low for an open source software.

We invite everyone to become one of these guys.

fix all bugs listed previously

And establish world peace.

refactor all Hubzilla code to use object oriented programation, a popular framework

Personally, I'm not a fan of the cult of object-oriented programming, which is often (but not always) less efficient and makes it difficult to understand the code and also I prefer not to use frameworks and libraries without real need.

And you are welcome (one more time) to join to the development team and make it better.
That's was about "to be constructive".

sync

Wed, 09 Jun 2021 22:20:53 +0000

And you are welcome (one more time) to join to the development team and make it better.

Really? "Welcome"?
Why not answer to the questions the willing developers asked on the issue? That's how you welcome new developers...

less efficient

Modern caches threw this remark away. By the way, there are many performance errors in the code you could fix if this is important for you. But keeping old, outdated, bugged, unmaintainable code just for this false reason is blindness...

Max Kostikov

Wed, 09 Jun 2021 22:25:27 +0000 last edited: Wed, 09 Jun 2021 22:33:07 +0000

@sync

Why not answer to the questions the willing developers asked on the issue?

Because all the questions related to the issue were answered. If there was no answer to something, then this question does not make sense and the explanation of why will take a lot of time with a low chance of being understood.

By the way, there are many performance errors in the code you could fix if this is important for you

That's what I'm trying to do last months. If this important for me. :laughing:

Caranistar

Thu, 10 Jun 2021 00:17:48 +0000

I find that the questions make very sense, and your attitude is deplorable. No wonder you can't manage to attract new developers with that code and that behavior...

emaxmax

Wed, 16 Jun 2021 10:11:45 +0000

@Max Kostikov

Wrong. There was a several issues involved and several bugs was discovered and fixed within less than one working day after a reproducible case was provided.

I can read code. I was talking of the bug reported 6 monthes ago, which was corrected with 1 line in the comit (and no tests updated or documentation added). I know other bugs were fixed too, but they were not reported in the issue.

Personally, I'm not a fan of the cult of object-oriented programming, which is often (but not always) less efficient

I don't know who told you that, but it's completely wrong (OO code are translated in procedural code when the project is built, so they have exaclty the same perf)

Because all the questions related to the issue were answered.

No: I listed 5 questions unanswered.

Max Kostikov

Wed, 16 Jun 2021 19:58:44 +0000 last edited: Wed, 16 Jun 2021 20:08:14 +0000

@emaxmax

I can read code.

It seems you can not which completely deprives value of your entire subsequent text for me.

cb7f604332cf39

Wed, 16 Jun 2021 20:00:00 +0000

We've got Corona-Time. Do you have some time to learn a new language?
May be php fits to your requirements.
Start a fork and rebuild everything from the ground with OO approach.
Cause this is what you're asking for.
It's not that easy as you write.
There won't be a smooth easy migration from procedural to OO.

This is a huge mass of work and you need to understand everything in detail to do this in a propper way.
And not every developer is able to support the object oriented style. Do you do?
Some are no professionals but more hobby developer.
Some of them works in IT but are no developer (like me: I'm a network admin).
My own php skills are limited for example.

As multiple people wrote: this is FOSS.
Lot's of people invested a lot of spare time to write this project over serveral years.
Nobody works here as an full time employee.
In the past we lost some good developers (inclu. Mike, Thomas and others).
These people have their own mind, targets and ideas.
And the history told us that communication between people is sometimes complicated.
Some devs are already burned and gone.

So I just wanne say to all devs: thank you for all the work you made for this great project.
Please take the time you need.

emaxmax

Wed, 16 Jun 2021 20:19:18 +0000

It seems you can not

Yet I can, and I can see poor code poorly patched.

which completely deprives value of your entire subsequent text for me.

This is the way you are going to improve? Denying reality just as you did with the issues you couldn't reproduce? How mature...

sync

Thu, 17 Jun 2021 14:57:52 +0000

It seems @emaxmax is right, unless if, @Max Kostikov, you can point us to the unit test updated, and the documentation improved. I search for a long time (since the bug is actually not fully fixed yet), I dug in your commits, and the rest of the files you didn't update, and I found nothing else. Just this frightening ORDER BY...

Max Kostikov

Thu, 17 Jun 2021 22:17:31 +0000 last edited: Fri, 18 Jun 2021 08:35:24 +0000

@sync
The main issue wasn't related to wiki itself but it helped to fix it.
https://framagit.org/hubzilla/core/-/commit/35df50c39d95e19dcd7e67bd3328059dbb591b66
https://framagit.org/hubzilla/core/-/commit/07525c5b4594858b2b9a748a1d0cbc571fa49c7c
There are the couple of other issues found and fixed when wiki testing
https://framagit.org/hubzilla/core/-/commit/8394d4857c3f7a4fcfdd983348fa7bf81ae76347

sync

Fri, 18 Jun 2021 09:38:25 +0000

So @emaxmax is right: no tests updated, no documentation added. Yet someone pointed it here: https://framagit.org/hubzilla/core/-/commit/8394d4857c3f7a4fcfdd983348fa7bf81ae76347#note_929579
I would add myself that you should not mess SQL and business logic in the same file. Create a method for all your

q("SELECT * FROM item WHERE uid = %d AND resource_type = '%s' AND resource_id = '%s' AND item_deleted = 0

Caranistar

Tue, 03 Aug 2021 01:24:27 +0000

The issue 1513 is still there.

Page created: https://hub.pericles.hu/wiki/caranistar/MtG/Aznaph (#hubzilla 6.0.1)

Page correctly sync: https://lokal.social/wiki/caranistar/MtG/Aznaph (#hubzilla 5.6)
https://social.portaesgnos.org/wiki/caranistar7520/MtG/Aznaph (#hubzilla 5.6)

Page not even created on the clone:
https://rkor.info/wiki/caranistar/MtG/Aznaph (#hubzilla 6.0)
https://zotum.net/wiki/caranistar/MtG/Aznaph (6.1.2)
https://kuluary.c44.pl/wiki/caranistar5759/MtG/Aznaph (#hubzilla 6.0.1)
https://pisma.bgzashtita.es/wiki/caranistar/MtG/Aznaph (#hubzilla 6.0.1)

Zotlabs|Hubzilla Development

hubzilla-development@zotlabs.org